Add compositor_free branch in Compatibility scene renderer free function
#88873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct, you probably also need to add: It's a bit weird with these (including environment) as their implementation is in the base system but then the free logic is in each renderer. |
clayjohn
force-pushed
the
GLES3-compositor-free
branch
from
ce331cd
to
57f8b88
Compare
|
@BastiaanOlij Done! |
akien-mga
changed the title
compositor_free branch in Compatibility scene renderer free function
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #88861
See the equivalent code in the other renderers:
godot/servers/rendering/dummy/rasterizer_scene_dummy.h
Lines 171 to 173 in bb6b06c
godot/servers/rendering/renderer_rd/renderer_scene_render_rd.cpp
Lines 1199 to 1200 in bb6b06c
CC @BastiaanOlij